Skip to content
This repository has been archived by the owner on Jan 5, 2022. It is now read-only.

Update XboxCtrlrInput.cs #11

Merged
merged 3 commits into from
Feb 10, 2014
Merged

Update XboxCtrlrInput.cs #11

merged 3 commits into from
Feb 10, 2014

Conversation

KariVargr
Copy link
Contributor

Added GetDPadDown and GetDPadUp for Both All and Targeted Controllers.

Added GetDPadDown and GetDPadUp for Both All and Targeted Controllers.
}
else
{
inputCode = DetermineDPad(padDirection, 0);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to me that GetDPadUp() and GetDPadDown() will work on Windows, Mac, and Linux(Wireless Controller) (although I have not tested yet). My question is: will this work with Linux(Wired Controller)?

This else block that this comment points to (lines 438-451) is for Linux with Wired Controllers and I don't see a difference between this block and the equivalent else block in GetDPad().How would one get the up and down state of the D-Pad using axes?

@KariVargr
Copy link
Contributor Author

I basicly converted it from the Standard Button Down and up command with what was in the DPad.

I have not Tested it on anything other then windows myself yet. and i see what you mean with the last Else Statement not able to read what the up check. I had a different version where i held boolen for each of the controllers DPad direction and changes them as they key was pressed, using that to check its state, and return the release and press info that would have worked for Windows Mac Linux Wired and Wireless.
Thinking about that again now i might have a way to solve this for Linux Wired

Updated GetDPadDown and GetDPadUp to return false for all Linux Wired, until a supported update to this can be created.
@KariVargr
Copy link
Contributor Author

Still trying to find a solution to the Wired Linux Checking, updated the files to just return false as a place holder in that location.

@JISyed
Copy link
Owner

JISyed commented Feb 10, 2014

I will merge your changes, but I won't update my wiki documentation until we can figure out a way for GetDPadDown() and GetDPadUp() to work on Linux with wired controller. Thank you for contributing.

JISyed pushed a commit that referenced this pull request Feb 10, 2014
Merge XboxCtrlrInput.cs from ProjectEnder. Adds GetDPadUp() and GetDPadDown(), but not Linux-ready.
@JISyed JISyed merged commit 3965888 into JISyed:master Feb 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants