Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mention resolution #55

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Improve mention resolution #55

merged 2 commits into from
Jul 5, 2023

Conversation

MartinJM
Copy link

@MartinJM MartinJM commented Jul 5, 2023

This adds server nicknames to any mentions of users and replaces channel references with the channel names.

Couple of things that might need more consideration:

  • With channel references it is not possible to see if they actually existed at the archival time.
  • Some references could actually be Markdown references, but they are not made into those.
  • If a user has a Discord server nick and a different name in CTFNote, there will be two names in parentheses behind the mention (first the Discord nick, then the CTFNote name).

@JJ-8 JJ-8 changed the base branch from main to 0-add-discord-integration-downstream July 5, 2023 14:36
JJ-8
JJ-8 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Owner

@JJ-8 JJ-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it myself and works perfectly fine! Format looks great. Thank you for your contribution!

@JJ-8 JJ-8 merged commit 81c3adf into JJ-8:0-add-discord-integration-downstream Jul 5, 2023
@JJ-8 JJ-8 mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJ-8 JJ-8 JJ-8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinJM @JJ-8