Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tabledense task display #74

Merged
merged 10 commits into from
Mar 16, 2024
Merged

Added tabledense task display #74

merged 10 commits into from
Mar 16, 2024

Conversation

markfijneman
Copy link

@markfijneman markfijneman commented Mar 7, 2024

No description provided.

@markfijneman markfijneman marked this pull request as draft March 7, 2024 18:34
@markfijneman markfijneman marked this pull request as ready for review March 7, 2024 18:37
@markfijneman markfijneman changed the title Fix table layout button grouping on small screens Added tabledense task display Mar 7, 2024
front/src/components/Task/TaskBtnGroup.vue Outdated Show resolved Hide resolved
front/src/components/Task/TaskBtnGroup.vue Show resolved Hide resolved
front/src/components/Task/TaskCard.vue Outdated Show resolved Hide resolved
@markfijneman markfijneman requested a review from JJ-8 March 16, 2024 16:04
Copy link
Owner

@JJ-8 JJ-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Is this an edge case you want to resolve? Maybe add wrapping anyway if there are too many tags?

Also have a look at this when the description is a bit long:
image
If the tags would claim less space, the description would not be this horrible. So my point is about the tags again, not that you should fix wrapping for the description (since this was not originally done either).

Mobile view is even more annoying since you only see tags on your first view, not even the titles. Of course, table view in mobile is not performing great so it won't probably be used a lot.

@markfijneman
Copy link
Author

markfijneman commented Mar 16, 2024

@JJ-8 Category tag wrapping should be fixed now.

@markfijneman markfijneman requested a review from JJ-8 March 16, 2024 17:13
@JJ-8 JJ-8 merged commit 585564b into JJ-8:main Mar 16, 2024
@markfijneman markfijneman deleted the tabledense-layout branch March 20, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants