-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caches work incorrectly: additionalEditorconfig should be @Input instead of @Internal #750
Comments
I would love a PR for this. There should be some tests already that are fairly similar you can copy from to get started on your test. Let me know if you get stuck and I can assist. |
m-burst
added a commit
to m-burst/ktlint-gradle
that referenced
this issue
Apr 2, 2024
…e checks and caching Fixes JLLeitschuh#750
I finally got around to this and opened #758. Could you please take a look? |
Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
additionalEditorconfig
Expected behaviour: ktlint will be re-run with updated editorconfig and will not report the violations
Actual behaviour: ktlint will use the cached result
As far as I understand, the cause of this is that
BaseKtLintCheckTask.additionalEditorconfig
is not checked when computing cache keys for the task because it is marked as@Internal
, and should be@Input
instead.Unless there are any reasons for this property being
@Internal
, I would gladly submit a PR changing it to@Input
.The text was updated successfully, but these errors were encountered: