Add support to disable particular rules via extension property #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapchicoma
changed the title
JLLeitschuh
reviewed
Sep 10, 2019
| @@ -147,6 +150,12 @@ abstract class BaseKtlintCheckTask( | |||
| enabledReports | |||
| .map { it.asArgument() } | |||
| .forEach { argsWriter.println(it) } | |||
| disabledRules | |||
| .get() | |||
| .fold("") { acc, rule -> "$acc,$rule" } | |||
There was a problem hiding this comment.
I think you want joinToString or something here. You can pass a seperator.
There was a problem hiding this comment.
You are right! Totally forgot about it 🤦♂️
There was a problem hiding this comment.
Fixed in force-pushed update.
Tapchicoma
force-pushed
the
add-disabled-rules
branch
from
3faccd1 to
cf2485d
Compare
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
|
Formatting violation: |
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Tapchicoma
force-pushed
the
add-disabled-rules
branch
from
cf2485d to
d7b8947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267.