Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for older versions of gradle and ktlint #720

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

wakingrufus
Copy link
Collaborator

@wakingrufus wakingrufus commented Oct 23, 2023

change default version of ktlint to 1.0.1
increase minimum supported gradle version to 7.4.1
increase minimum supported ktlint version to 0.47.1
support ktlint 1.0.1
remove retry plugin as it is included in enterprise plugin now
update code to utilize kotlin-dsl
fix ktlint errors
upgrade build to gradle 8 and add toolchain resolver
update reporter samples to ktlint 1.0.1

@wakingrufus wakingrufus force-pushed the drop-gradle-6 branch 3 times, most recently from 40620f0 to 31b19ce Compare October 23, 2023 20:04
@wakingrufus wakingrufus force-pushed the drop-gradle-6 branch 13 times, most recently from b87d28f to 2fe7004 Compare November 8, 2023 17:14
@wakingrufus wakingrufus marked this pull request as ready for review November 8, 2023 18:56
@JLLeitschuh
Copy link
Owner

Does the supported Gradle version match the version range supported by the Android plugin?

@wakingrufus
Copy link
Collaborator Author

Does the supported Gradle version match the version range supported by the Android plugin?

We will be moving to requiring AGP 7.0 which requires Gradle 7.0, so this will be aligned.

increase minimum supported gradle version to 7.4.1
increase minimum supported ktlint version to 0.47.1
support ktlint 1.0.1
remove retry plugin as it is included in enterprise plugin now
upgrade project gradle
update code to utilize kotlin-dsl
fix ktlint errors
upgrade build to gradle 8 and add toolchain resolver
update reporter samples to ktlint 1.0.1
Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JLLeitschuh
Copy link
Owner

JLLeitschuh commented Nov 25, 2023

Nice work on this, quite a bit of effort was clearly required. I'm very impressed!

@JLLeitschuh JLLeitschuh merged commit a547de5 into main Nov 25, 2023
16 of 17 checks passed
@JLLeitschuh JLLeitschuh deleted the drop-gradle-6 branch November 25, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants