Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version Catalog Setup Instructions in README #770

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

soleil-colza
Copy link
Contributor

This update supplements the documentation by adding instructions for configuring the Ktlint Gradle plugin using a version catalog.

Since using version catalogs is now recommended officially and is used by default in newly generated projects, this addition provides essential guidance for both Groovy and Kotlin DSL users, making it easier to integrate the plugin into modern project setups.

@wakingrufus
Copy link
Collaborator

Thanks for this!
Please add an entry to the CHANGELOG (our PR checks require this), and I will be happy to merge it.

@wakingrufus wakingrufus self-assigned this Aug 30, 2024
@wakingrufus
Copy link
Collaborator

your build failures are due to #771 I will update you when this is resolved

@soleil-colza
Copy link
Contributor Author

Thanks for this! Please add an entry to the CHANGELOG (our PR checks require this), and I will be happy to merge it.

Thank you so much for the rapid action @wakingrufus and apologies for not adding it to the CHANGELOG, I've added it now so could you please check it out when you're available?
And noted about #771 !

Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable change. Thanks!

Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JLLeitschuh JLLeitschuh merged commit e2a0a63 into JLLeitschuh:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants