Don't interpret chat messages as HTML

Fixes #638
JLyne · Dec 23, 2023 · 2c8473e · 2c8473e
1 parent 32b4875
commit 2c8473e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/components/chat/ChatMessage.vue b/src/components/chat/ChatMessage.vue
@@ -19,7 +19,7 @@
 		<PlayerImage v-if="showFace && message.playerAccount" :player="message.playerAccount" width="16" height="16" class="message__face" />
 		<span v-if="messageChannel" class="message__channel" v-html="messageChannel"></span>
 		<span v-if="showSender" class="message__sender" v-html="message.playerName"></span>
-		<span class="message__content" v-html="messageContent"></span>
+		<span class="message__content">{{ messageContent }}</span>
 	</li>
 </template>
 

diff --git a/src/components/map/marker/PlayerMarker.vue b/src/components/map/marker/PlayerMarker.vue
@@ -111,7 +111,9 @@ export default defineComponent({
 
 			updateChatBalloon = () => {
 				const content = playerChat.value.reduceRight<string>((previousValue, currentValue) => {
-					return previousValue + `<span>${currentValue.message}</span>`;
+          const span = document.createElement('span');
+          span.appendChild(document.createTextNode(currentValue.message || ''));
+					return previousValue + span.outerHTML;
 				}, '');
 
 				//Update balloon if content has changed