forked from IceSentry/bevy
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't lock external edges during simplification #28
Closed
SparkyPotato
wants to merge
3
commits into
JMS55:meshlet-bigger-clusters
from
SparkyPotato:meshlet-bigger-clusters
Closed
Don't lock external edges during simplification #28
SparkyPotato
wants to merge
3
commits into
JMS55:meshlet-bigger-clusters
from
SparkyPotato:meshlet-bigger-clusters
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
So it doesn't get lost:
|
I ended up using zeux's slightly simpler code that just locks any vertex used by more than 1 group. It'll be part of an upcoming PR :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Only lock the edges internal to a mesh when simplifying groups, such that non-solid meshes will still have their edges simplified, leading to much better performance at lower LOD levels.
Solution
We generate a list of edge vertices at the beginning of the import, which define the border of the mesh as a whole. Then, when a group is being simplified, we calculate the border of the group, and remove any vertices that are in the mesh border.
The current implementation seriously affects the performance of the builder, since the entire vertex buffer has to be traversed to find the differences between the mesh border and group border. This can probably be optimized by generating a mini-vertex buffer for each group. The border computation code isn't particularly well-optimized either.