WIP #132 Add 'canViewProfiles' permission

JN-Jones · May 24, 2015 · c24c0db · c24c0db
1 parent dc88d8d
commit c24c0db
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php
@@ -13,6 +13,8 @@
 use MyBB\Core\Database\Repositories\ProfileFieldGroupRepositoryInterface;
 use MyBB\Core\Database\Repositories\UserProfileFieldRepositoryInterface;
 use MyBB\Core\Exceptions\UserNotFoundException;
+use MyBB\Core\Permissions\PermissionChecker;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 
 class UserController extends AbstractController
 {
@@ -43,25 +45,31 @@ public function __construct(
 	 * @param int                                  $id
 	 * @param ProfileFieldGroupRepositoryInterface $profileFieldGroups
 	 * @param Breadcrumbs                          $breadcrumbs
+	 * @param PermissionChecker                    $permissionChecker
 	 *
 	 * @return \Illuminate\View\View
 	 */
 	public function profile(
 		$slug,
 		$id,
 		ProfileFieldGroupRepositoryInterface $profileFieldGroups,
-		Breadcrumbs $breadcrumbs
+		Breadcrumbs $breadcrumbs,
+		PermissionChecker $permissionChecker
 	) {
 		$user = $this->users->find($id);
 
 		if (!$user) {
 			throw new UserNotFoundException;
 		}
 
-		$groups = $profileFieldGroups->getAll();
-
 		$breadcrumbs->setCurrentRoute('user.profile', $user);
 
+		if (!$permissionChecker->hasPermission('user', null, 'canViewProfiles')) {
+			throw new AccessDeniedHttpException;
+		}
+
+		$groups = $profileFieldGroups->getAll();
+
 		return view('user.profile', [
 			'user' => $user,
 			'profile_field_groups' => $groups

diff --git a/database/seeds/PermissionRoleTableSeeder.php b/database/seeds/PermissionRoleTableSeeder.php
@@ -119,6 +119,12 @@ public function run()
 				'value'         => PermissionChecker::NO,
 				'content_id'    => 0
 			],
+			[
+				'permission_id' => $this->perm('canViewProfiles'),
+				'role_id'       => $this->role('banned'),
+				'value'         => PermissionChecker::NEVER,
+				'content_id'    => null
+			],
 		];
 
 		DB::table('permission_role')->insert($permissions_role);

diff --git a/database/seeds/PermissionsTableSeeder.php b/database/seeds/PermissionsTableSeeder.php
@@ -82,6 +82,11 @@ public function run()
 				'content_name'    => 'forum',
 				'default_value'   => PermissionChecker::NO
 			],
+			[
+				'permission_name' => 'canViewProfiles',
+				'content_name'    => null,
+				'default_value'   => PermissionChecker::YES
+			],
 		];
 
 		DB::table('permissions')->insert($permissions);