upgrade to error_prone 2.3.3-SNAPSHOT + patch for Java 13 compatibility

See google/error-prone#1106 (comment)

git-svn-id: https://josm.openstreetmap.de/svn/trunk@14784 0c6e7542-c601-0410-84e7-c038aed88b3b

build.xml

@@ -380,7 +380,7 @@ Build-Date: ${build.tstamp}
             <compilerarg value="-Xlint:unchecked"/>
             <!-- Undocumented argument to ignore "Sun internal proprietary API" warning, see http://stackoverflow.com/a/13862308/2257172 -->
             <compilerarg value="-XDignore.symbol.file"/>
-            <compilerarg value="-Xplugin:ErrorProne -Xep:ReferenceEquality:OFF -Xep:ImmutableEnumChecker:OFF -Xep:FutureReturnValueIgnored:OFF -Xep:FloatingPointLiteralPrecision:OFF -Xep:ShortCircuitBoolean:OFF -Xep:StringSplitter:OFF -Xep:JdkObsolete:OFF -Xep:UnnecessaryParentheses:OFF -Xep:EqualsGetClass:OFF -Xep:ThreadPriorityCheck:OFF -Xep:UndefinedEquals:OFF"/>
+            <compilerarg value="-Xplugin:ErrorProne -Xep:ReferenceEquality:OFF -Xep:ImmutableEnumChecker:OFF -Xep:FutureReturnValueIgnored:OFF -Xep:FloatingPointLiteralPrecision:OFF -Xep:ShortCircuitBoolean:OFF -Xep:StringSplitter:OFF -Xep:JdkObsolete:OFF -Xep:UnnecessaryParentheses:OFF -Xep:EqualsGetClass:OFF -Xep:ThreadPriorityCheck:OFF -Xep:UndefinedEquals:OFF -Xep:MixedMutabilityReturnType:OFF -Xep:OverrideThrowableToString:OFF -Xep:JavaTimeDefaultTimeZone:OFF -Xep:UnusedVariable:OFF -Xep:EqualsUsingHashCode:OFF"/>
             <compilerarg line="-Xmaxwarns 1000"/>
             <exclude name="org/openstreetmap/josm/io/audio/fx/*.java" if:set="noJavaFX"/>
         </javac>

src/org/openstreetmap/josm/actions/ToggleAction.java

@@ -120,8 +120,7 @@ protected void notifySelectedState() {
      * the component already set the selected state.
      * This method needs to be called especially if the action is associated with a keyboard shortcut to ensure correct selected state.
      * @param e ActionEvent that trigerred the action
-     * @see <a href="https://weblogs.java.net/blog/zixle/archive/2005/11/changes_to_acti.html">Changes to Actions in 1.6</a>
-     * @see <a href="https://docs.oracle.com/javase/6/docs/api/javax/swing/Action.html">Interface Action</a>
+     * @see <a href="https://docs.oracle.com/javase/8/docs/api/javax/swing/Action.html">Interface Action</a>
      */
     protected final void toggleSelectedState(ActionEvent e) {
         if (e == null || !(e.getSource() instanceof JToggleButton ||

src/org/openstreetmap/josm/data/osm/visitor/paint/PaintColors.java

@@ -78,19 +78,12 @@ public enum PaintColors {
      */
     AREA_TEXT(marktr("areatext"), Color.LIGHT_GRAY);
 
-    /**
-     * The name of the color
-     */
-    private final String name;
-    private final Color defaultColor;
     private final NamedColorProperty baseProperty;
     private final CachingProperty<Color> property;
 
     PaintColors(String name, Color defaultColor) {
         baseProperty = new NamedColorProperty(name, defaultColor);
         property = baseProperty.cached();
-        this.name = name;
-        this.defaultColor = defaultColor;
     }
 
     /**