error: allow user and external group ids

[sam-golioth]

The V2 Error group field only accepted header.GroupId, which would lead to validation errors when smpclient received v2 error responses from SMP groups beyond the standard set. This change allows creating ErrorV2 instances for both User Groups defined in the tree (i.e. Intercreate) as well as for User Groups defined outside of the tree.

Let me know if there's a more preferred way to solve this problem!

[JPHutchins]

Thanks! It came up before, and we added this GroupIdField: ffea1a5

It's nice because it has the explicit behavior of attempting to parse as GroupId, then UserGroupId, before falling back to int.

Sorry to create maintenance work, but perhaps it makes sense to relocate that GroupIdField definition and then use it in the error.py file?

[sam-golioth]

Thanks! It came up before, and we added this GroupIdField: ffea1a5

It's nice because it has the explicit behavior of attempting to parse as GroupId, then UserGroupId, before falling back to int.

Sorry to create maintenance work, but perhaps it makes sense to relocate that GroupIdField definition and then use it in the error.py file?

Can do! I'm thinking header.py makes the most sense for where to put it. AnyGroupId is only used in Unions, so we could remove it and use GroupIdField in place of the Unions instead:

smp/smp/header.py

Line 140 in b32db57

group_id: Union[AnyGroupId, GroupId, UserGroupId]

smp/smp/message.py

Line 31 in b32db57

_GROUP_ID: ClassVar[smpheader.GroupId | smpheader.UserGroupId | smpheader.AnyGroupId]

What do you think?

[JPHutchins]

Thanks! Removed more lines than it added - ideal!