Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAC LS is not removing frozen kerbals. #58

Closed
JPLRepo opened this issue Jul 19, 2016 · 1 comment
Closed

TAC LS is not removing frozen kerbals. #58

JPLRepo opened this issue Jul 19, 2016 · 1 comment
Assignees
@JPLRepo
Labels
bug

Comments

@JPLRepo
Copy link
Owner

JPLRepo commented Jul 19, 2016 

13 hours ago, GrzesiekB said:

Hi all.

First I wanted to say that I love this mod. Unfortunately I also love TAC LS. So.. TAC is still not compatible with Deep Freeze as I see it. When thawing a kerbal, he consumes supplies for the period when he was hibernating. I have the latest version of TAC LS (v0.12.2) and DF (v0.22.3). Here's my output_log: https://www.dropbox.com/s/yaxkffuozpeufp7/output_log.txt?dl=0

Maybe somebody could write a quick fix like that one for previous versions of TAC? Thanks for help.

OK, I can confirm this is an issue. When you freeze a kerbal you should see this in your log:
Deleting Frozen crew member: but I am not seeing that in your log, and that is why they still appear in TAC LS crew roster (they should be removed). But it looks like they are not being removed.
I will have to investigate what is going on.
JPLRepo pushed a commit to JPLRepo/TacLifeSupport that referenced this issue Jul 19, 2016
Fix DeepFreeze Integration
6002e97 
DeepFreeze integration broken.
JPLRepo/DeepFreeze#58
TAC LS not recognising frozen kerbals as the wrapper integration was not
working.
Fixed.
@JPLRepo JPLRepo mentioned this issue Jul 19, 2016
Merged
@JPLRepo
Copy link
Owner Author

JPLRepo commented Jul 19, 2016

PR created to fix problem. Awaiting TAC LS to merge PR and publish new version.
KSP-RO/TacLifeSupport#29

@JPLRepo JPLRepo added the bug label Jul 19, 2016
@JPLRepo JPLRepo self-assigned this Jul 19, 2016
@JPLRepo JPLRepo closed this as completed Sep 4, 2016
keyspace pushed a commit to keyspace/TacLifeSupport that referenced this issue Oct 2, 2016
@keyspace
Fix DeepFreeze Integration
c2ba9a8 
DeepFreeze integration broken.
JPLRepo/DeepFreeze#58
TAC LS not recognising frozen kerbals as the wrapper integration was not
working.
Fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPLRepo JPLRepo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JPLRepo