Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can compile on both Windows and Linux #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasarmel
Copy link

Hello,
I've made some changes but the most important thing is you should be able to compile under windows too.
I've used std::thread instead of Posix pthread().
I haven't made any change on the Authorization branch.
Thanks for your job :)

@thomasarmel
Copy link
Author

mjpeg.zip
Compiled with Visual Studio Enterprise 2019 and CLion

@JulesThuillier
Copy link

Hello ! Thank you for porting this soft to Windows..
I am trying to use it in Windows 10, VS2019, C++14, but I am encoutering a issue as son as it starts.
"unlocked of unowned mutex", in th efirst line of MJPEG::write(cv::Mat frame), when trying to lock mutex_writer.
Any idea ?
I am looking into fixing this issue, I'll post it here if I find the answer.

@thomasarmel
Copy link
Author

thomasarmel commented Jun 3, 2021

Hello @JulesThuillier ,
Important precision: the code runs only in Release mode on my machine, because of OpenCV (but compiles well in both cases).
What about running directly my program from the message above ?
Actually I only "cleaned" the code, standardized it from C-like functions to C++ SL and added the correct #define for the cross-platform compilation.
I compiled the code with C++ 11 and OpenCV 4, what about you ?

@thomasarmel
Copy link
Author

One more precision: I suggest you to compile with a recent release of OpenCV or at least compile with libjpeg-turbo support.

@JulesThuillier
Copy link

Hello @thomasarmel, I actually found a fix yesterday, I'll propose a solution on your git as a PR you'll tell me what you think about it. I might do it only next week thought I just took some holidays 😅

@thomasarmel
Copy link
Author

Ok thank you have a nice "coding we" ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants