Fix tuples #21
Merged
Fix tuples #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the10thWiz
force-pushed
the
fix-tuples
branch
from
c881e85 to
ee37466
Compare
Previously, tuples did not implement `Transient`, even if all elements did. Now, up to 6-tuples do. This also adds a number of impls for `Timeless`, so that more tuples work. Finally, adds a number of tests to validate that this works as expected.
the10thWiz
force-pushed
the
fix-tuples
branch
from
ee37466 to
0878556
Compare
JRRudy1
reviewed
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tuples did not implement
Transient, even if all elements did. Now, up to 6-tuples do.This also adds a number of impls for
Timeless, so that more tuples work.Finally, adds a number of tests to validate that this works as expected.