Aircraft's Systems sub-directories are missing in the wheel packages.

[bcoconni]

Discussed in #683

^{Originally posted by cjdupuis1 July 21, 2022}
I have been having trouble with a lot of the example scripts that come with the download. For example, the Short-S23 is missing the Short_S23-hydrodynamics system file. The ah1s helicopter model is missing files. It seems like only about half of the example scripts run without errors. I can provide more examples if necessary.

Are all of the example scripts supposed to run?

[seanmcleod]

@bcoconni in addition to aircraft specific Systems sub-directories some aircraft also include an Engines sub-directory, e.g. the ah1s that I checked when I looked into this issue.

[bcoconni]

Oups ! You're absolutely right @seanmcleod. Thanks for the heads up 👍

[seanmcleod]

The other thing I noticed last night when looking into this and finding the relevant code in setup.py.in was whether os.path.exists() etc. are case sensitive or not across Windows and Unix.

For example we have aircraft\MB339\systems, i.e. all lower case for systems whereas other aircraft have \Systems etc.

So I didn't submit a pull request last night to fix the missing sub-directories for aircraft since I wanted to double-check the case sensitivity issue. But you then pushed a commit, so I'll let you double-check 😉

In general Windows has a case preserving but case insensitive file system, but in general Unix file systems are case preserving and case sensitive.

[dpculp]

Some historical background on the capitalization.  The lower case is JSBSim-style whereas the upper case is FlightGear-style. Originally the aircraft model was to be spread across three directories so that the engines and systems could be shared.  In FlightGear it made more sense to package the model in a single directory using subdirectories for the engines and systems, to ease the distribution of models.  So the loading algorithm was changed to look for the subdirectories as well as the external directories.

…

On 7/27/22 02:58, Sean McLeod wrote: The other thing I noticed last night when looking into this and finding the relevant code in |setup.py.in| was whether |os.path.exists()| etc. are case sensitive or not across Windows and Unix. For example we have |aircraft\MB339\systems|, i.e. all lower case for |systems| whereas other aircraft have |\Systems| etc. So I didn't submit a pull request last night to fix the missing sub-directories for aircraft since I wanted to double-check the case sensitivity issue. But you then pushed a commit, so I'll let you double-check 😉 In general Windows has a case preserving but case insensitive file system, but in general Unix file systems are case preserving and case sensitive. — Reply to this email directly, view it on GitHub <#687 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFDBF2PQ7PR4GS3BPJEWZNDVWEB35ANCNFSM54XXX63Q>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[bcoconni]

The other thing I noticed last night when looking into this and finding the relevant code in setup.py.in was whether os.path.exists() etc. are case sensitive or not across Windows and Unix.

Regarding the case sensitivity topic, I'd say we are in a mixed situation since the default systems folder is all lower case:

jsbsim/src/FGFDMExec.cpp

Lines 99 to 101 in 16bb270

	AircraftPath = "aircraft";
	EnginePath = "engine";
	SystemsPath = "systems";

while the Systems folder under the aircraft has a capital letter :

jsbsim/src/models/FGFCS.cpp

Lines 611 to 620 in 16bb270

	SGPath FGFCS::FindFullPathName(const SGPath& path) const
	{
	SGPath name = FGModel::FindFullPathName(path);
	if (systype != stSystem || !name.isNull()) return name;
	name = CheckPathName(FDMExec->GetFullAircraftPath()/string("Systems"), path);
	if (!name.isNull()) return name;
	return CheckPathName(FDMExec->GetSystemsPath(), path);
	}

The same issue applies to engines vs Engines, by the way:

jsbsim/src/models/FGPropulsion.cpp

Lines 439 to 448 in 16bb270

	SGPath FGPropulsion::FindFullPathName(const SGPath& path) const
	{
	if (!ReadingEngine) return FGModel::FindFullPathName(path);
	SGPath name = CheckPathName(FDMExec->GetFullAircraftPath()/string("Engines"),
	path);
	if (!name.isNull()) return name;
	return CheckPathName(FDMExec->GetEnginePath(), path);
	}

So strictly speaking the code that has been committed to master (commits 3016b7c and 16bb270) is correct 😄. However we might want to allow both systems and Systems as aircraft subdirectories (as well as engines and Engines) ?

For example we have aircraft\MB339\systems, i.e. all lower case for systems whereas other aircraft have \Systems etc.

I can't find any MB339 aircraft in JSBSim, are you referring to an aircraft from FlightGear ?

So I didn't submit a pull request last night to fix the missing sub-directories for aircraft since I wanted to double-check the case sensitivity issue. But you then pushed a commit, so I'll let you double-check 😉

Yes, sorry. I was so eager to fix my error that I pushed a fix as soon as I could.

[seanmcleod]

Yes, sorry.

Definitely no problem 😉.

I can't find any MB339 aircraft in JSBSim, are you referring to an aircraft from FlightGear ?

Hmm, just double-checked via git status and I see that MB339 is something I added locally at some stage. Can't remember when or from where. So, good chance it could be from FlightGear.