fix: FromItem alias must not shade an actual table (found before)

- fixes #2035 Signed-off-by: Andreas Reichel <andreas@manticore-projects.com>
JSQLParser · Jul 10, 2024 · d8207aa · d8207aa
1 parent e8bc446
commit d8207aa
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java b/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
@@ -1330,9 +1330,6 @@ public void visit(UseStatement use) {
 
  @Override
  public <S> Void visit(ParenthesedFromItem parenthesis, S context) {
- if (parenthesis.getAlias() != null) {
- otherItemNames.add(parenthesis.getAlias().getName());
- }
  parenthesis.getFromItem().accept(this, context);
  // support join keyword in fromItem
  visitJoins(parenthesis.getJoins(), context);

diff --git a/src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java b/src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java
@@ -497,5 +497,17 @@ void testSubqueryAliasesIssue1987() throws JSQLParserException {
  assertThat(tables).containsExactlyInAnyOrder("a", "b");
  assertThat(tables).doesNotContain("a1");
  }
+
+ @Test
+ void testSubqueryAliasesIssue2035() throws JSQLParserException {
+ String sqlStr = "SELECT * FROM (SELECT * FROM A) AS A \n" +
+ "JOIN B ON A.a = B.a \n" +
+ "JOIN C ON A.a = C.a;";
+ Set<String> tables = TablesNamesFinder.findTablesOrOtherSources(sqlStr);
+ assertThat(tables).containsExactlyInAnyOrder("A", "B", "C");
+
+ tables = TablesNamesFinder.findTables(sqlStr);
+ assertThat(tables).containsExactlyInAnyOrder("B", "C");
+ }
 }