Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using own Feature - constant for "delete with returning" #1597

Closed
gitmotte opened this issue Jul 23, 2022 · 4 comments
Closed

Using own Feature - constant for "delete with returning" #1597

gitmotte opened this issue Jul 23, 2022 · 4 comments

Comments

@gitmotte
Copy link
Contributor

#1527 introduced DELETE with RETURNING and used Feature.insertReturningExpressionList
within the validation net.sf.jsqlparser.util.validation.validator.DeleteValidator - the Feature.insertReturningExpressionList is part of the validation group FeaturesAllowed.INSERT and therefore only allowed for INSERT statements.

The bugfix fixes the problem with a new feature constant Feature.deleteReturningExpressionList which is part of the validation group FeaturesAllowed.DELETE.
gitmotte added a commit to gitmotte/JSqlParser that referenced this issue Jul 23, 2022
@gitmotte
Using own Feature - constant for "delete with returning" JSQLParser#1597
9cdff4f
gitmotte added a commit to gitmotte/JSqlParser that referenced this issue Jul 23, 2022
@gitmotte
Using own Feature - constant for "delete with returning" JSQLParser#1597
7933899
@manticore-projects
Copy link
Contributor

Thank you for helping me out! I honestly have no idea how this validation framework works and tried brute force.

@gitmotte
Copy link
Contributor Author

Are the correlations clearer for you now, when you look at the changes?

@gitmotte
Copy link
Contributor Author

gitmotte commented Jul 23, 2022 •
edited
Loading

I've added a "Further development" section to the wiki of my fork - could you please merge it to the original wiki of JSQLParser @wumpz ?

https://github.com/gitmotte/JSqlParser/wiki/Examples-of-SQL-Validation#further-development

(don't know how to add merge requests for wiki-pages)

wumpz pushed a commit that referenced this issue Jul 25, 2022
@gitmotte
Using own Feature - constant for "delete with returning" #1597 (#1598)
d321848
@wumpz
Copy link
Member

wumpz commented Jul 26, 2022

merged it :) manually

@wumpz wumpz closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wumpz @manticore-projects @gitmotte