Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SHOW INDEX from table #1704

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Added support for SHOW INDEX from table #1704

merged 4 commits into from
Jan 31, 2023

Conversation

jayant-kumar-yadav
Copy link
Contributor

RDBMS like MySql and Mariadb allows checking indexes on a table using
SHOW INDEX from

Added support for same.

@jayant-kumar-yadav jayant-kumar-yadav mentioned this pull request Dec 28, 2022
Closed
wumpz
wumpz requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for improving JSqlParser. Your PR is very promising. Could you address my two remarks?

src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Show resolved Hide resolved
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Show resolved Hide resolved
manticore-projects
manticore-projects reviewed Jan 15, 2023
View reviewed changes
Copy link
Contributor

@manticore-projects manticore-projects left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No STAR imports please, its against policy.
Checkstyle would reject it anyways.

Never mind.

wumpz
wumpz requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved you that your PRs do run a Github build action. There seem to be a JavaDoc problem introduced. Please correct your PR so that it is build successfully.

src/main/java/net/sf/jsqlparser/parser/feature/Feature.java Outdated Show resolved Hide resolved
@wumpz wumpz merged commit a261832 into JSQLParser:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manticore-projects manticore-projects manticore-projects left review comments

@wumpz wumpz Awaiting requested review from wumpz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayant-kumar-yadav @wumpz @manticore-projects