New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests support multi-os and higher versions of jdk #1886

Merged

manticore-projects merged 2 commits into JSQLParser:master from human-user:master

Nov 8, 2023

Contributor

human-user commented Nov 8, 2023 •

edited

Loading

When I run unit tests, there are two failures:

ParserKeywordsUtilsTest#getAllKeywords failed to run. Because my os is windows and the regex in ParserKeywordsUtils#getAllKeywordsUsingRegex seems not support multi-os.
Compilation fails when using JDK 17. Nashorn has been deprecated after jdk11 and removed after jdk15.

human-user added 2 commits

November 7, 2023 17:06


fix: tokenBlockPattern support \r\n or \r

4eb7558


test: remove nashorn ignore annotation to support jdk11+

9e6b0fa

Contributor

manticore-projects commented Nov 8, 2023

Greetings!
Thank you for your contribution, especially the fix of the Regex is great.

manticore-projects merged commit 97e9229 into JSQLParser:master

3 of 5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment