feat: Build with Automatic-Module-Name for compatibility with the Java module system. #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broneill
changed the title
|
It does not harm, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the Java module system with my project, but JSQLParser doesn't use modules. As a result, I need to use the --add-reads ALL-UNNAMED hack in order to depend on it.
Building a project with the Automatic-Module-Name feature allows it to work with the module system, but without actually depending on the module system itself. This change makes it easier to integrate JSQLParser with projects that are using the Java module system.
I ran both the Maven and Gradle builds and verified that
Automatic-Module-Name: net.sf.jsqlparserappears in the jar's MANIFEST.MF file.