Guard Values against null/empty values #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes modified by this commit are `DoubleValue`, `LongValue`, and `TimeValue`. Both `null` and empty strings provided to their constructors fail, but they provide very different error messages (NullPointerException and StringIndexOutOfBoundsException), which is neither sensible nor helpful in debugging. This commit adds a guard to throw `IllegalArgumentException` for both cases in order to improve coherency and usefulness of the error messages.
|
Looks good. ./gradlew :spotlessApplyand then I would merge. |
|
@manticore-projects Thank you for the swift response. |
|
Thank you for your contribution, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to implement suitable guards for the constructors of the classes
DoubleValue,LongValue, andTimeValue.Both
nulland empty strings provided to their constructors fail, but they provide very different error messages (NullPointerException and StringIndexOutOfBoundsException),which is neither sensible nor helpful in debugging.
This PR adds a guard to throw
IllegalArgumentExceptionfor both cases in order to improve coherency and usefulness of the error messages.