feature/fix: parsing inserts/updates/delete within CTEs #2055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In Postgres it is valid syntax to have insert, update or delete statements appear within CTEs.
See here on https://www.postgresql.org/docs/current/sql-select.html
e.g.
The current version of the parser fails when faced with these statements as only
ParenthesedSelect
s are allowed to appear within CTEsSolution
Change the
WithItem
class so that...WithItem
no longer extendsParenthesedSelect
WithItem
has type T where T extends the new interfaceParenthesedStatement
ParenthesedSelect
implementsParenthesedStatement
ParenthesedInsert
+ParenthesedUpdate
+ParenthesedDelete
are also implementationsParenthesedStatement
Notes
I could definitely do with some feedback on the approach Ive taken here.
I've done my best to avoid impacting any existing functionality. The method
getWithItemsList
in various classes now returns aList<WithItem<?>>
object rather than aList<WithItem>
object. I think this should be the most "disruptive" thing I've included.