Resolve Flutter 3.29 analyze issues

JSUYA · Feb 18, 2025 · 3ad001a · 3ad001a
1 parent c6cb477
commit 3ad001a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -127,7 +127,6 @@ linter:
     # - one_member_abstracts # too many false positives
     - only_throw_errors # this does get disabled in a few places where we have legacy code that uses strings et al
     - overridden_fields
-    - package_api_docs
     - package_names
     - package_prefixed_library_names
     # - parameter_assignments # we do this commonly
@@ -215,7 +214,6 @@ linter:
     - unnecessary_to_list_in_spreads
     - unreachable_from_main
     - unrelated_type_equality_checks
-    - unsafe_html
     - use_build_context_synchronously
     - use_colored_box
     # - use_decorated_box # leads to bugs: DecoratedBox and Container are not equivalent (Container inserts extra padding)

diff --git a/packages/flutter_webrtc/example/flutter_webrtc_demo/lib/src/utils/device_info_web.dart b/packages/flutter_webrtc/example/flutter_webrtc_demo/lib/src/utils/device_info_web.dart
@@ -1,12 +1,11 @@
-// ignore: avoid_web_libraries_in_flutter
-import 'dart:html' as html;
+import 'package:web/web.dart' as web;
 
 class DeviceInfo {
   static String get label {
     return 'Flutter Web';
   }
 
   static String get userAgent {
-    return 'flutter-webrtc/web-plugin 0.0.1 ( ${html.window.navigator.userAgent} )';
+    return 'flutter-webrtc/web-plugin 0.0.1 ( ${web.window.navigator.userAgent} )';
   }
 }
diff --git a/...ages/flutter_webrtc/example/flutter_webrtc_example/lib/src/get_user_media_sample_web.dart b/...ages/flutter_webrtc/example/flutter_webrtc_example/lib/src/get_user_media_sample_web.dart
@@ -1,10 +1,10 @@
 // ignore: uri_does_not_exist
 import 'dart:core';
-import 'dart:html' as html;
 
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_webrtc/flutter_webrtc.dart';
+import 'package:web/web.dart' as web;
 
 /*
  * getUserMedia sample
@@ -114,8 +114,7 @@ class _GetUserMediaSampleState extends State<GetUserMediaSample> {
       _mediaRecorder = null;
     });
     print(objectUrl);
-    // ignore: unsafe_html
-    html.window.open(objectUrl, '_blank');
+    web.window.open(objectUrl, '_blank');
   }
 
   void _captureFrame() async {

diff --git a/packages/sqflite/example/analysis_options.yaml b/packages/sqflite/example/analysis_options.yaml
@@ -48,7 +48,6 @@ linter:
     - no_duplicate_case_values
     - non_constant_identifier_names
     - omit_local_variable_types
-    - package_api_docs
     - package_prefixed_library_names
     - prefer_generic_function_type_aliases
     - prefer_is_empty
@@ -63,7 +62,6 @@ linter:
     - unnecessary_null_aware_assignments
     - unnecessary_statements
     - unrelated_type_equality_checks
-    - unsafe_html
     - valid_regexps
 
     - constant_identifier_names