support suger-high #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JSerZANP
commented
Dec 3, 2023
examples/web/css/shaku.css
Outdated
| @@ -4,12 +4,13 @@ pre.shaku { | |||
| overflow-x: auto; | |||
| } | |||
|
|
|||
| pre.shaku .line { | |||
| pre.shaku .line, | |||
| pre.shaku .sh__line { | |||
There was a problem hiding this comment.
separate these 2 sets of CSS
JSerZANP
commented
Dec 3, 2023
| --sh-string: #00a99a; | ||
| --sh-keyword: #f47067; | ||
| --sh-comment: #a19595; | ||
| --sh-jsxliterals: #6266d1; |
JSerZANP
commented
Dec 3, 2023
| @@ -48,7 +48,7 @@ function isShakuDirectiveHighlightInline(str: string): { | |||
| shift: number; | |||
| isHighlightInline: boolean; | |||
| } { | |||
| const significantLine = str.replace(/ /g, ""); | |||
| const significantLine = str.replace(/\s/g, ""); | |||
JSerZANP
commented
Dec 3, 2023
|
|
||
| ### Patch Changes | ||
|
|
||
| - bump |
JSerZANP
commented
Dec 3, 2023
| @@ -0,0 +1,52 @@ | |||
| # shaku-code-annotate-shiki | |||
JSerZANP
commented
Dec 3, 2023
| @@ -0,0 +1,52 @@ | |||
| # shaku-code-annotate-shiki | |||
|
|
|||
| <ruby>釈<rp>(<rp><rt>Shaku</rt><rp>)<rp></ruby>- _elucidate, explain_ | |||
There was a problem hiding this comment.
- also update shaku homepage
JSerZANP
commented
Dec 3, 2023
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "name": "shaku-code-annotate-sugar-high", | |||
| "version": "0.1.4", | |||
JSerZANP
commented
Dec 3, 2023
| * 4. the first meaningful token has the comment body | ||
| * - find the first explanation that is not `punctuation.definition`. | ||
| */ | ||
| function parseComment( |
JSerZANP
commented
Dec 3, 2023
| @@ -0,0 +1,26 @@ | |||
| export const defaultCode = ` | |||
JSerZANP
commented
Dec 3, 2023
|
|
||
| return ( | ||
| <button onClick={handleClick}> | ||
| {/* ^ */} |
JSerZANP
commented
Dec 3, 2023
|
|
||
| // @ts-ignore | ||
| // this type is missing from sugar-high | ||
| const TokenTypes = sh.SugarHigh.TokenTypes; |
There was a problem hiding this comment.
- create an issue on sugar-high
JSerZANP
commented
Dec 3, 2023
| type RawToken = [number, string]; | ||
|
|
||
| export function highlight(code: string) { | ||
| const tokens = sh.tokenize(code); |
There was a problem hiding this comment.
- move the logic into codeToHTML?
JSerZANP
commented
Dec 3, 2023
| ); | ||
| contents.push( | ||
| // in sugar-high, we don't need md parsing | ||
| nextLine.line.config.content |
There was a problem hiding this comment.
- this needs to be escaped!
JSerZANP
commented
Dec 3, 2023
| ); | ||
| j += 1; | ||
| } | ||
| html += renderComponent({ |
There was a problem hiding this comment.
- separate renderComponent() into two, one supports HTML and sanitize. one does escape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43