Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch FamPlex and HGNC IDs in the index from conceptIds to prefixed original IDs #190

Closed
khituras opened this issue Dec 17, 2022 · 0 comments
Assignees

Comments

@khituras
Copy link
Member

Using the concept IDs obscured the original IDs which we need for the table view and Excel download. Thus, the original IDs needed to be retrieved from Neo4j which takes a long time for large results. Instead, we now index the original ID with a prefix to differentiate HGNC group IDs - which are numbers - from NCBI Gene IDs - also numbers - and map them to concept IDs, preferred names etc. just like the genes. This way, the index contains the (prefixed) original ID and the concept ID.

@khituras khituras self-assigned this Dec 17, 2022
khituras added a commit that referenced this issue Dec 17, 2022
…nd HGNC Group IDs.

As a consequence of #190, more mapping file were needed that partly repeated mechanisms that were already present for NCBI Gene IDs. Instead of adding more and more files, the NCBI Gene ID files were generalized to include FamPlex and HGNC Group IDs. However, HGNC Group IDs are just numbers which collides with the NCBI Gene IDs. To avoid this, FamPlex and HGNC Group IDs are now source-prefixed. This needed more handling but seems to fit now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant