Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sascha changelog 0.1.17-49 #78

Closed
1 task done
SchSascha opened this issue Dec 11, 2017 · 3 comments
Closed
1 task done

Sascha changelog 0.1.17-49 #78

SchSascha opened this issue Dec 11, 2017 · 3 comments
Assignees

Comments

@SchSascha
Copy link
Collaborator

SchSascha commented Dec 11, 2017

@SchSascha SchSascha added this to the 0.1.17-49 milestone Dec 11, 2017
@SchSascha SchSascha self-assigned this Dec 11, 2017
@SchSascha
Copy link
Collaborator Author

Sadly overdue as of annoying bug issues that I could not resolve. The logic is already there.

Fixed bug with 2b7ca93 and table gets correct preferred names from neo4j assigned.
As all the other widgets, e.g. Sankey widget are not modified, this issue remains open until further change is included that post-processes results once they are there.
I tried this already by modifying setEvents method in EventRetrievalResult class, yet this led to an error (null pointer). @khituras, any thoughts?

Plan
Once location is identified, I include the post-process such that it is available to all widgets once results are there.
This is resolved by tomorrow 12-12, or Wednesday 12-13 the latest.

@khituras
Copy link
Member

khituras commented Dec 12, 2017 via email

@SchSascha
Copy link
Collaborator Author

After discussion moved post processing for preferred names to service EventResponseProcessingService.
Issue resolved and thus this changelog issue as well.
Will be reopened if modifications have to be included upon pull request reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants