Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atid shown in results instead of gene symbol #68

Closed
khituras opened this issue Oct 24, 2017 · 8 comments
Closed

atid shown in results instead of gene symbol #68

khituras opened this issue Oct 24, 2017 · 8 comments
Assignees
Labels

Comments

@khituras
Copy link
Member

To reproduce:

  • define a list with gene ID 196
  • find 2 cases on the first page of the result table
@khituras
Copy link
Member Author

To view such events in ElasticSearch, use the following query:

{
"query": {
"nested": {
"path": "events",
"query": {
"match": {
"events.argumentpreferrednames": "atid99264"
}
}, "inner_hits":{"stored_fields":"*"}
}
}
}

@khituras
Copy link
Member Author

To view the respective top homology in Neo4j, query:

match (t:AGGREGATE {id:'atid99264'}) return t

@khituras
Copy link
Member Author

khituras commented Oct 24, 2017

The error is as follows:
We currently write the preferred names right into the index. To do this, we map the atids to the preferred names. We employ a mapping file created by the createGepiProductionResources.sh script in the semedico-app project. However, the script first produces a mapping file from names to atids and we want it the other way round. So the following AWK is issued:
awk '{print $2 "\t" $1}' atid2prefname.map
Unfortunately, the totally anonymous author of this line who can never be found and is also a ghost and thus can't ever be catched even if found (just believe me and don't think about it!) failed to specify that the column seperator in the mapping file is the tab character.
Now, the correct preferred name for atid99264 (just as an example) would be "androgen receptor". Thus, the script outputs "recepter androgen" and drops the actual atid completely.
Solutions (just one of these, not both):

  1. reindex
  2. use the Neo4j DB directly to access preferred names

@SchSascha
Copy link
Collaborator

After discussion option 2. will be used.

@SchSascha SchSascha added this to the 0.3 milestone Nov 15, 2017
@SchSascha
Copy link
Collaborator

Also it appears that the current atid - tid mapping file (hypernyms file) is currently inconsistent with the used neo4j db. See also issue #70.
For our tool we still should switch to lookup in neo4j for the preferred name.

@SchSascha SchSascha modified the milestones: 0.3, 0.1.49 Dec 4, 2017
@SchSascha
Copy link
Collaborator

Initial setup with e07ade8
Needs testing - void onUpdateTableData in TableResultWidget currently throws exception.

SchSascha added a commit that referenced this issue Dec 13, 2017
…eProcessingService, such that all widgets take advantage of corrected preferred names. Closes #68.
SchSascha added a commit that referenced this issue Dec 19, 2017
…eProcessingService, such that all widgets take advantage of corrected preferred names. Closes #68.
@SchSascha
Copy link
Collaborator

SchSascha commented Jan 5, 2018

When searching for AhR (196) I realised there are still tid and atid numbers in the resulting table.
Will work on this when I am back in office.

@SchSascha
Copy link
Collaborator

The commit 28ae7ea by @khituras has resolved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants