0.2 #110
Merged
0.2 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the JavaScript lo-dash utilities library on the way. Fixed bugs and cleaned things up. Note that currently ONLY the common partners code is working. Next up will be to bring back the classic frequency-based sankey.
Idea: Data shouldn't go multiple times to the client. Also, filtering often does not require contact to the server. So let the data JS module cache data and let the client to filtering on its own. For this, the widget layout now can switch off its default ajax content loading. Then, the specific widgets have to take care of their DOM elements and data loading on their own. The data module now has methods to get data from the server, through the index page. The idea is that all required data formats have a name such as "relation counts" or "neighboursofnode" and such stuff. This can then be cached within the browser. The current issue is that the cache has to be emptied when a new search is issued.
Separating the node order from the link weights.
The reason was that the WidgetManager didn't create a new Widget object if its internal map already knew a Widget by the given name. But with the Ajax loading the map wouldn't be refreshed but the HTML code would. So the elements manipulated by the old Widget object did not exist any more and the newly added Widget object was never created because the map already contained a Widget for each widget name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.