Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.table depends->imports #3

Merged
merged 1 commit into from
Oct 2, 2019
Merged

data.table depends->imports #3

merged 1 commit into from
Oct 2, 2019

Conversation

MichaelChirico
Copy link

Thanks for using data.table! We noticed you are Depending on us and recently decided to strongly discourage downstream packages from doing so -- we think Imports is always better.

This PR attempts to make the migration from Depends to Imports for data.table.

If you have a strong reason for preferring Depends, we'd love to hear it over at our issue tracker:

Rdatatable/data.table#3076

@MichaelChirico
Copy link
Author

I'm not sure what's up with the massive difference in the NAMESPACE. Seems to be whitespace (try ?w=1 in the URL) but still

@JWiley JWiley merged commit e9501e6 into JWiley:master Oct 2, 2019
@MichaelChirico MichaelChirico deleted the dt_import branch October 2, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants