Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Reference $EDITOR environment variable in QuickEdit.sh #385

Closed
ningen opened this issue Jul 16, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@ningen
Copy link
Contributor

ningen commented Jul 16, 2024

I am Japanese and am using the translation function to write this issue.

Feature Request

Description

Reference $EDITOR environment variable in QuickEdit.sh

Use Case

I used this repository to build a hyperland environment.
When I tried to change the settings, nano started.
I wanted to use neovim, so I set the $EDITOR variable because I knew that in linux, the editor you want to use is set to $EDITOR by default.
I was hoping that I would be able to use neovim now, but I was surprised that nano still started.
By making this change, new users can use their favorite editor without hesitation.

Proposed Solution

As the title suggests, if $EDITOR is set, that editor will be used.
If not set, use nano.

Alternatives

I modified QuickEdit.sh myself.

Additional Information

[Add any other information about the feature request here. For example, you might include links to similar features in other projects, or screenshots or diagrams to help explain your idea.]

@ningen ningen added the enhancement New feature or request label Jul 16, 2024
@ningen
Copy link
Contributor Author

ningen commented Jul 16, 2024

I can prepare a merge request.
We will probably create a merge request within 2-3 days.
This is my first OSS contribution, so there may be some mistakes.

@ningen
Copy link
Contributor Author

ningen commented Jul 16, 2024

I created a pull request.
Please check.

#386

@JaKooLit
Copy link
Owner

merged into development for further testing.

thanks..

Made a comment on PR that there is no need to create an issue for creating PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants