Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use $EDITOR and nano if not set #386

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ningen
Copy link
Contributor

@ningen ningen commented Jul 16, 2024

Pull Request

Description

issue: #385

Changed QuickEdit.sh to reference $EDITOR variable.
If not set, nano will be used as is currently the case.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

Additional context

@ningen
Copy link
Contributor Author

ningen commented Jul 19, 2024

I made a correction to the PR (I didn't delete the part that needed to be deleted in the description).
Could you please review it?

@JaKooLit JaKooLit changed the base branch from main to development July 19, 2024 15:01
@JaKooLit JaKooLit merged commit fc555c0 into JaKooLit:development Jul 19, 2024
@JaKooLit
Copy link
Owner

Thanks... But next time, you dont have to file or open an issue for a PR.

@ningen
Copy link
Contributor Author

ningen commented Jul 19, 2024

Thank you.
I thought an Issue was required for a Pull Request. From now on, I will not create such a case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants