Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules - Make taskbar ignore the drop-down terminal when it's hidden. #407

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

asunekants
Copy link
Contributor

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Summary: Add kitty-dropterm class to the taskbar waybar module's ignore list, to stop the drop-down terminal from appearing in it.

  • Motivation: Drop-down terminal is showing in the taskbar waybar module even when the drop down terminal is hidden, which was really annoying me. As it's created by pypr with the class "kitty-dropterm", it's removed by adding the class to the module's ignore list.

  • No Dependencies needed

  • Didn't find an open issue related to that.

  • No idea who'd be reviewing this.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
    Fixes bug [Bug]: Dropdown terminal appears in the taskbar module #406

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • Documentation update (non-breaking change; modified files are limited to the documentations)

  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)

  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

Screenshot_19-Aug_23-04-36_27084

Additional context

Small config change in waybar modules.

JaKooLit and others added 2 commits August 16, 2024 08:05
Added kitty-dropterm class to the taskbar ignore list, to stop the drop-down terminal from appearing in it.
@JaKooLit JaKooLit changed the base branch from main to AGS-Dev August 19, 2024 23:17
@JaKooLit JaKooLit changed the base branch from AGS-Dev to development August 19, 2024 23:17
@JaKooLit
Copy link
Owner

thanks

@JaKooLit JaKooLit merged commit ccbcf33 into JaKooLit:development Aug 19, 2024
@JaKooLit JaKooLit mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants