Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable static build of landing page #1724

Merged
merged 20 commits into from
Apr 23, 2023
Merged

chore: enable static build of landing page #1724

merged 20 commits into from
Apr 23, 2023

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Jan 23, 2023

Fixes #1603 and fixes #1725.

@tobiasdiez
Copy link
Member Author

Storybook pulls in a few cjs + browser stuff, which breaks ssr. Thus let's wait with this until #1672 is fixed.

@tobiasdiez tobiasdiez marked this pull request as draft January 23, 2023 11:01
@tobiasdiez tobiasdiez changed the title chore: enable static build of blog and landing page chore: enable static build of landing page Apr 22, 2023
tobiasdiez added a commit that referenced this pull request Apr 23, 2023
As preperation for #1724.
Turns out FontAwesome doesn't really support SSR as of now (had
hydration mismatch).
@tobiasdiez tobiasdiez marked this pull request as ready for review April 23, 2023 10:22
@tobiasdiez tobiasdiez merged commit 0621a2d into main Apr 23, 2023
@tobiasdiez tobiasdiez deleted the static-build branch April 23, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate SSR Enable static mode for static files
1 participant