Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and additions #100

Merged
merged 3 commits into from
Jul 3, 2022
Merged

Fixes and additions #100

merged 3 commits into from
Jul 3, 2022

Conversation

jhossbach
Copy link
Contributor

No description provided.

@jhossbach jhossbach changed the title Add Materials Physics Today Fixes and additions May 17, 2022
@jhossbach
Copy link
Contributor Author

I have a question regarding the use of ampersands &, I often come across \& in my .bib files when an ampersand is used, JabRef doesn't seem to recognize that journaltitle if the name is not exactly the same. Do we need to add entries for all occurences of & and \& and and as well?

@Siedlerchr
Copy link
Member

Thanks for being patient, this is a good question. I think the journal abbrev handling should be improved so that ampersands and escaped ampersands are considered for equality check

@jhossbach
Copy link
Contributor Author

The logic you mentioned should be adressed but this PR is good to go nevertheless. You might change the header level LICENSE.md to fix your failing tests though

@koppor
Copy link
Member

koppor commented Jul 4, 2022

We should do unescaped & only. JabRef should generate \& in the .bib file.

Reason: The abbreviation file should be usable outside of JabRef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants