Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StringTokenizer #163

Closed
oscargus opened this issue Aug 28, 2016 · 8 comments · Fixed by JabRef/jabref#9730
Closed

Replace StringTokenizer #163

oscargus opened this issue Aug 28, 2016 · 8 comments · Fixed by JabRef/jabref#9730

Comments

@oscargus
Copy link

See JabRef#1877 and the link in the comment http://stackoverflow.com/questions/691184/scanner-vs-stringtokenizer-vs-string-split

@Siedlerchr
Copy link
Member

I just learned the Regex/Matcher Split can also be used in combination with streams:
http://winterbe.com/posts/2015/03/25/java8-examples-string-number-math-files/

@koppor
Copy link
Member

koppor commented Nov 10, 2022

One can search for StringTokenizer using Ctrl+Shift+F.

@PFvanBeerendonk
Copy link

Would like to take this issue.

@koppor
Copy link
Member

koppor commented Mar 16, 2023

Assigned!

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@PFvanBeerendonk
Copy link

I have some minor questions.

  1. I am considering not replacing QuotedStringTokenizer since it is its own class, and does not use deprecated class StringTokenizer.
  2. All changes are internal, and all internal parts should already be tested. So I assume I do not need to add test cases (since I'm not adding or changing functionality?)

@Siedlerchr
Copy link
Member

  1. Well, if there are no tests cases you should add one!

@PFvanBeerendonk
Copy link

PR is ready

@koppor
Copy link
Member

koppor commented Apr 3, 2023

Thank you for investigating this. Comments on the PR.

@koppor koppor closed this as completed Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Apr 3, 2023
PFvanBeerendonk referenced this issue in PFvanBeerendonk/jabref Apr 3, 2023
Decided not to do fix koppor#163 so we will not replace StringTokenizer.
Related test cases are here
PFvanBeerendonk referenced this issue in PFvanBeerendonk/jabref Apr 3, 2023
Decided not to do fix koppor#163 so we will not replace StringTokenizer.
Related test cases are here
koppor pushed a commit that referenced this issue Apr 5, 2023
…ngTokenizer-tests

Write test cases for StringTokenizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment