changed Keyword.of to accept List<String> instead of varargs (#13871)

* changed Keyword.of to accept List<String> instead of varargs

* changed Keyword.of to accept List<String> instead of varargs

Author: siddhantkore

jablib/src/main/java/org/jabref/model/entry/Keyword.java

@@ -1,5 +1,6 @@
 package org.jabref.model.entry;
 
+import java.util.List;
 import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
@@ -23,21 +24,23 @@ public Keyword(String keyword) {
 
     /// Connects all the given keywords into one chain and returns its root,
     /// e.g. "A", "B", "C" is transformed into "A > B > C".
-    public static Keyword of(String... keywords) {
-        if (keywords.length == 0) {
+    public static Keyword of(List<String> keywords) {
+        if (keywords.isEmpty()) {
             return new Keyword("");
         }
 
-        Keyword root = new Keyword(keywords[0]);
-        for (int i = 1; i < keywords.length; i++) {
-            root.addAtEnd(keywords[i]);
+        Keyword root = new Keyword(keywords.getFirst());
+        for (int i = 1; i < keywords.size(); i++) {
+            root.addAtEnd(keywords.get(i));
         }
         return root;
     }
 
     /// Converts a raw String to a single Keyword
     public static Keyword ofHierarchical(String rawString) {
-        return Keyword.of(rawString.split(Keyword.DEFAULT_HIERARCHICAL_DELIMITER.toString()));
+        return Keyword.of(Stream.of(rawString.split(Keyword.DEFAULT_HIERARCHICAL_DELIMITER.toString()))
+                        .map(String::trim)
+                        .toList());
     }
 
     @Override

jablib/src/test/java/org/jabref/model/entry/KeywordListTest.java

@@ -1,5 +1,7 @@
 package org.jabref.model.entry;
 
+import java.util.List;
+
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
@@ -81,15 +83,15 @@ void asStringAddsSpaceAfterDelimiter() {
 
     @Test
     void parseHierarchicalChain() {
-        Keyword expected = Keyword.of("Parent", "Node", "Child");
+        Keyword expected = Keyword.of(List.of("Parent", "Node", "Child"));
 
         assertEquals(new KeywordList(expected), KeywordList.parse("Parent > Node > Child", ',', '>'));
     }
 
     @Test
     void parseTwoHierarchicalChains() {
-        Keyword expectedOne = Keyword.of("Parent1", "Node1", "Child1");
-        Keyword expectedTwo = Keyword.of("Parent2", "Node2", "Child2");
+        Keyword expectedOne = Keyword.of(List.of("Parent1", "Node1", "Child1"));
+        Keyword expectedTwo = Keyword.of(List.of("Parent2", "Node2", "Child2"));
 
         assertEquals(new KeywordList(expectedOne, expectedTwo),
                 KeywordList.parse("Parent1 > Node1 > Child1, Parent2 > Node2 > Child2", ',', '>'));

jablib/src/test/java/org/jabref/model/entry/KeywordTest.java

@@ -1,6 +1,7 @@
 package org.jabref.model.entry;
 
 import java.util.HashSet;
+import java.util.List;
 import java.util.Set;
 
 import org.junit.jupiter.api.Test;
@@ -11,13 +12,13 @@ class KeywordTest {
 
     @Test
     void getPathFromRootAsStringForSimpleChain() {
-        Keyword keywordChain = Keyword.of("A", "B", "C");
+        Keyword keywordChain = Keyword.of(List.of("A", "B", "C"));
         assertEquals("A > B", keywordChain.getChild().get().getPathFromRootAsString('>'));
     }
 
     @Test
     void getAllSubchainsAsStringForSimpleChain() {
-        Keyword keywordChain = Keyword.of("A", "B", "C");
+        Keyword keywordChain = Keyword.of(List.of("A", "B", "C"));
         Set<String> expected = new HashSet<>();
         expected.add("A");
         expected.add("A > B");