Skip to content

Conversation

@siddhantkore
Copy link
Contributor

Closes #13602

Mandatory checks

CHANGELOG.md Outdated

### Changed

- We changed `Keyword.of` to accept `List<String>` instead of `varargs`.[#13602](https://github.com/JabRef/jabref/issues/13602)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entries only for user facing changes

CHANGELOG.md Outdated

### Changed

- We changed `Keyword.of` to accept `List<String>` instead of `varargs`.[#13602](https://github.com/JabRef/jabref/issues/13602)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, the changelog is user facing and this is only an internal thing

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful: Keyword.of does not create multiple Keywords or a List of Keywords, but one hierarchical one. Changes to List is in this case mostly cosmetic and using more modern java style with List safeties.

@siddhantkore
Copy link
Contributor Author

Hi @calixtus You right. Thanks for pointing this out and for clarification!

@trag-bot
Copy link

trag-bot bot commented Sep 13, 2025

@trag-bot didn't find any issues in the code! ✅✨

@calixtus calixtus added this pull request to the merge queue Sep 13, 2025
Merged via the queue into JabRef:main with commit 2d3cf9d Sep 13, 2025
34 checks passed
Siedlerchr added a commit that referenced this pull request Sep 13, 2025
* upstream/main:
  Chronological navigation in libraries (#13863)
  Adapt code style (#13874)
  LSP Refactor to use ranges instead of string matching (#13862)
  Use jspecify (#13873)
  changed Keyword.of to accept List<String> instead of varargs (#13871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use List data structure at Keyword.of()

3 participants