-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
changed Keyword.of to accept List<String> instead of varargs #13871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed Keyword.of to accept List<String> instead of varargs #13871
Conversation
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - We changed `Keyword.of` to accept `List<String>` instead of `varargs`.[#13602](https://github.com/JabRef/jabref/issues/13602) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entries only for user facing changes
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - We changed `Keyword.of` to accept `List<String>` instead of `varargs`.[#13602](https://github.com/JabRef/jabref/issues/13602) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, the changelog is user facing and this is only an internal thing
calixtus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Careful: Keyword.of does not create multiple Keywords or a List of Keywords, but one hierarchical one. Changes to List is in this case mostly cosmetic and using more modern java style with List safeties.
|
Hi @calixtus You right. Thanks for pointing this out and for clarification! |
|
@trag-bot didn't find any issues in the code! ✅✨ |
Closes #13602
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)