fix "collapse sub tree" functionality for groups tree - fixes #2319 (#…

…2416)
JabRef · Dec 21, 2016 · 599e21d · 599e21d
1 parent e6318f6
commit 599e21d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - We fixed an issue where groups containing brackets were not working properly. Fixes [#2394](https://github.com/JabRef/jabref/issues/2394).
 - We fixed issues with the [timestamp](http://help.jabref.org/en/TimeStamp) field. However, clearing with the clear button is not possible if timestamp format does not match the current settings. Fixes [#2403](https://github.com/JabRef/jabref/issues/2403).
 - Fixes [#2406](https://github.com/JabRef/jabref/issues/2406) so that the integrity check filter works again
+- Closing of subtrees in the groups panel using "close subtree" is working again. Fixes [#2319](https://github.com/JabRef/jabref/issues/2319).
 
 ### Removed
 

diff --git a/src/main/java/net/sf/jabref/gui/groups/GroupTreeNodeViewModel.java b/src/main/java/net/sf/jabref/gui/groups/GroupTreeNodeViewModel.java
@@ -151,11 +151,10 @@ public GroupTreeNode getNode() {
 
     /** Collapse this node and all its children. */
     public void collapseSubtree(JTree tree) {
-        tree.collapsePath(this.getTreePath());
-
-        for(GroupTreeNodeViewModel child : getChildren()) {
+        for (GroupTreeNodeViewModel child : getChildren()) {
             child.collapseSubtree(tree);
         }
+        tree.collapsePath(this.getTreePath());
     }
 
     /** Expand this node and all its children. */