Skip to content

Commit

Permalink
set jabrefHost.py executable
Browse files Browse the repository at this point in the history
  • Loading branch information
@LyzardKing
LyzardKing committed Oct 27, 2019
1 parent 9b19838 commit 60e7342
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 1 deletion.
Empty file modified buildres/linux/jabrefHost.py
100644 → 100755
View file
Empty file.
1 change: 0 additions & 1 deletion snap/snapcraft.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,3 @@ parts:
snapcraftctl build
snapcraftctl set-version "$(cat $SNAPCRAFT_PART_INSTALL/lib/app/JabRef.cfg | grep "app.version=" | cut -d'=' -f2)"
sed -i 's|/opt/jabref/lib/jabrefHost.py|/snap/bin/jabref.browser-proxy|g' $SNAPCRAFT_PART_INSTALL/lib/org.jabref.jabref.json
chmod +x $SNAPCRAFT_PART_INSTALL/lib/jabrefHost.py

3 comments on commit 60e7342

@Siedlerchr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, you are calling chmod+x in the yaml and that removed the bit?

@LyzardKing
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this didn't remove anything because it happens in the snapcraft vm.
Also I added this line because the executable bit was removed and I didn't realize.

@LyzardKing
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important thing in this PR is the change in permissions on the python script. The line in the snapcraff file si simply not needed

Please sign in to comment.