Fix threading issue with opening from recent libraries (#4943)

JabRef · May 3, 2019 · 99d99cf · 99d99cf
1 parent d4c6922
commit 99d99cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java b/src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java
@@ -161,6 +161,7 @@ public void openFiles(List<Path> filesToOpen, boolean raisePanel) {
             final List<Path> theFiles = Collections.unmodifiableList(filesToOpen);
 
             for (Path theFile : theFiles) {
+                //This method will execute the concrete file opening and loading in a background thread
                 openTheFile(theFile, raisePanel);
             }
 

diff --git a/src/main/java/org/jabref/gui/menus/FileHistoryMenu.java b/src/main/java/org/jabref/gui/menus/FileHistoryMenu.java
@@ -6,7 +6,6 @@
 import javafx.scene.control.Menu;
 import javafx.scene.control.MenuItem;
 
-import org.jabref.JabRefExecutorService;
 import org.jabref.gui.DialogService;
 import org.jabref.gui.JabRefFrame;
 import org.jabref.logic.l10n.Localization;
@@ -71,7 +70,7 @@ public void openFile(Path file) {
             setItems();
             return;
         }
-        JabRefExecutorService.INSTANCE.execute(() -> frame.getOpenDatabaseAction().openFile(file, true));
+        frame.getOpenDatabaseAction().openFile(file, true);
 
     }