Skip to content

Commit

Permalink
Fix #5615 side pane not remembering position (#5629)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ka0o0 authored and tobiasdiez committed Nov 18, 2019
1 parent eb06344 commit 9ab537f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We fixed an issue where the merge dialog showed the wrong text colour in "Dark" mode [#5516](https://github.com/JabRef/jabref/issues/5516)
- We fixed an issue where the author field was not correctly parsed during bibtex key-generation. [#5551](https://github.com/JabRef/jabref/issues/5551)
- We fixed an issue where notifications where shown during autosave. [#5555](https://github.com/JabRef/jabref/issues/5555)
- We fixed an issue where the side pane was not remembering its position. [#5615](https://github.com/JabRef/jabref/issues/5615)

### Removed

Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/jabref/gui/JabRefFrame.java
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ private void initLayout() {
head.setCenter(createToolbar());
setTop(head);

SplitPane.setResizableWithParent(sidePane, Boolean.FALSE);
splitPane.getItems().addAll(sidePane, tabbedPane);

// We need to wait with setting the divider since it gets reset a few times during the initial set-up
Expand All @@ -423,6 +422,8 @@ public void changed(ObservableValue<? extends Boolean> observable, Boolean oldVa

EasyBind.subscribe(sidePane.visibleProperty(), visible -> {
if (visible) {
// Run SplitPane.setResizableWithParent later to avoid miscalculation during initial layouting
Platform.runLater(() -> SplitPane.setResizableWithParent(sidePane, Boolean.FALSE));
if (!splitPane.getItems().contains(sidePane)) {
splitPane.getItems().add(0, sidePane);
setDividerPosition();
Expand Down

0 comments on commit 9ab537f

Please sign in to comment.