(Fix) #1 Cleaned code and added description

src/test/java/org/jabref/logic/net/ProxyTest.java

@@ -11,15 +11,13 @@
 import static org.junit.jupiter.api.Assertions.*;
 public class ProxyTest {
     /**
-
-     A Javadoc for the testProxyNotStoredInRegisterHttp() method which tests the ProxyRegisterer class
-     for HTTP protocol. This method checks if the proxy host, port, username are stored and password aren't stored in
-     the system register after registering the new proxy preference for HTTP protocol.
-
-     @throws IOException if an I/O error occurs.
+     * The method test if by storing a mock data of proxy information it get's stored as intented, where
+     * proxy host, port, username are stored and password aren't stored in
+     * the system register. It also ensures that the previous stored information isn't lost through extracting the
+     * information first and then restores it.
      */
     @Test
-    public void testProxyCredentialsMotStoredInRegisterHttp() throws IOException, BackingStoreException {
+    public void testProxyPasswordNotStoredInRegister(){
         //Get stored proxy preferences
         final JabRefPreferences preferences = JabRefPreferences.getInstance();
         //Globals.prefs = preferences;
@@ -33,15 +31,6 @@ public void testProxyCredentialsMotStoredInRegisterHttp() throws IOException, Ba
         String oldUsername = prox.getUsername();
         String oldPassword = prox.getPassword();
 
-        if(prox.shouldUseProxy()){
-            assertNotEquals(prox.getHostname(),"");
-            assertNotEquals(prox.getPort(),"");
-            System.out.println();
-        }
-        if(prox.shouldUseAuthentication()){
-            assertNotEquals(prox.getUsername(),"");
-            assertEquals(prox.getPassword(), "");
-        }
         //Part 2 of test
         String useProxy = "true";
         String hostname = "testName";
@@ -82,45 +71,6 @@ public void testProxyCredentialsMotStoredInRegisterHttp() throws IOException, Ba
         preferences.put(PROXY_PASSWORD, oldPassword);
     }
     /**
-
-     A Javadoc for the testProxyNotStoredInRegisterHttps() method which tests the ProxyRegisterer class
-     for HTTPS protocol. This method checks if the proxy host, port, username are stored and password aren't stored in
-     the system register after registering the new proxy preference for HTTPS protocol.
-
-     @throws IOException if an I/O error occurs.
-
-    @Test
-    public void testProxyCredentialsMotStoredInRegisterHttps() throws IOException {
-        String oldhost = System.getProperty("http" + ".proxyHost", "");
-        String oldport = System.getProperty("http" + ".proxyPort", "");
-        String olduser = System.getProperty("http" + ".proxyUser", "");
-        String oldpassword = System.getProperty("http" + ".proxyPassword", "");
-
-        Boolean useProxy = true;
-        String hostname = "testName";
-        String port = "8080";
-        Boolean useAuthentication = true;
-        String username = "testUserName";
-        String password = "testPassword";
-
-        ProxyPreferences proxyPref = new ProxyPreferences(useProxy, hostname,port,useAuthentication,username,password);
-        ProxyPreferences oldProxyPref = new ProxyPreferences(useProxy, oldhost,oldport,useAuthentication,olduser,oldpassword);
-
-        assertNotEquals(hostname , oldhost);
-        assertNotEquals(port , oldport);
-        assertNotEquals(username, olduser);
-        assertNotEquals(password, oldpassword);
-
-        ProxyRegisterer.register(proxyPref);
-
-        assertEquals(hostname , System.getProperty("https" + ".proxyHost", "")  );
-        assertEquals(port , System.getProperty("https" + ".proxyPort", "")  );
-        assertEquals(username, System.getProperty("https" + ".proxyUser", "")  );
-        //assertNotEquals(password, System.getProperty("http" + ".proxyPassword", "")  );
-        // Last line shoud be incommented when password not stored in register anymore.
-
-        //reset to what it was before
-        ProxyRegisterer.register(oldProxyPref);
-    }
+     * Add an additional test for testing that password get's stored somehow!
      */
 }