-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immediate Search (Incremental search) Disable option #1034
Comments
We should maybe do some small benchmarks how fast our search is and if it can/needs to be improved. |
These should be the critical lines of code though: // Search if user press enter
searchField.addActionListener(e -> performSearch());
// Subscribe to changes to the text in the search field in order to "live search"
JTextFieldChangeListenerUtil.addChangeListener(searchField, e -> performSearch()); or rather, adding a parameter to performSearch which determines if a checkbox should be checked before searching. |
There's a tentative version available for download in about 20 minutes at http://builds.jabref.org/livesearch (@ajbelle, this is based on the most recent version of JabRef, still I do not think it should break your massive file links...) |
Thank you EASTER BUNNIES @oscargus and Co. I have been using 3.3dev-snapshot-2016-03-25-livesearch-55fc5f2 for several hours and it is working great. The "search on typing" icon is exactly what was required :-) Could I suggest the case sensitive icon would be more intuitive if one of the letters was capitalised, say |
Good to hear that it worked! There is this icon which is meant to be used for case sensitive: Not sure if it is much better. Makes very much sense if you are English speaking, maybe not so much otherwise. (We are trying to use provided icons.) The text indicates that this is an alternative version of another icon, but I cannot seem to find it. |
That would be easily recognised by anyone using a Roman based letter set. It took me a while to realise that was a suit 'case' :-) Most Asians and Middle easterns I know using JabRef know more than enough English and the basic keyboard that I doubt anyone would complain. Maybe people still using Runes or Ogham script may struggle LOL. THX again. |
Regarding the case sensitive icon, I created an issue so that a better icon will be created in the future in our icon font: Templarian/MaterialDesign#1100 |
@ajbelle how many entries do you have in your 45mb file? I have created a JabRef version with a very fast search. Can you try it out if this would solve your problem? http://builds.jabref.org/fast-search/ In my tests, searching with 40k entries was acceptable on my machine, with a slight delay for warmup. Btw. filter is faster than float. |
THAT IS GREAT. Mine is 30k entries (size is given in the question below), but many are lengthy and include abstracts ... My problem with V3.2 was that it locked up typing entry long enough to mess it up and be annoying. The search time itself was not too bad. Your fix has solved that issue, and the search is lightning fast. A side question, my file size dropped from 50MB to about 45MB when I moved to Ver3.2. In Notepad++ line count dropped from 512634 to 483231. I could not spot what had changed and assumed it was a better parsing ‘clearing out’ dead lines, however in this current testing I reverted back to Ver2.1 and it shot back up!!!! |
Good to hear that it solved your issue 😄 |
@ajbelle we changed the bibentry layout format a little bit - this could be the effect of it. |
Result = JabRef immediately searches, blocking further typing into the search box
Apparent Reason = Large file takes time to search so this interrupts typing until it frees up.
User Experience: Very annoyingly, and time wasting .
Why in Stable Release: On a small test.bib file this delay is not noticeable, so it was not picked up during debugging.
On older JabRef versions that had Search in the LHS panel, I turned off
Incremental search
and the problem went away, but this disable functionality has been removed! Discussion can be found at #104 @tobiasdiez suggested I create this issue. According to @tobiasdiez the issue is separate, but turning offIncremental search
used to fix it.The text was updated successfully, but these errors were encountered: