Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new entry using ISBN is always added as "misc" #10348

Closed
2 tasks done
ghost opened this issue Sep 8, 2023 · 2 comments · Fixed by #10359
Closed
2 tasks done

new entry using ISBN is always added as "misc" #10348

ghost opened this issue Sep 8, 2023 · 2 comments · Fixed by #10359
Labels
component: fetcher [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@ghost
Copy link

ghost commented Sep 8, 2023 •
edited by ghost
Loading

JabRef version

5.10 (latest release)

Operating system

Windows

Details on version and operating system

Windows 10 22H2

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

When I added a new entry (a book) using a ISBN using jabref 5.9, it was added as a book.

afbeelding

In jabref 5.10 it's added as "misc" for each book ISBN you try to add...
It's definitely different from jabref 5.9 which I used to add many books. Never "misc" was used as type when using a ISBN.

examples of ISBN:

978-0-8229-4557-4

9780674240346

978-0-8160-5962-1

Appendix

...

Log File 
Paste an excerpt of your log file here
@Siedlerchr
Copy link
Member

Siedlerchr commented Sep 8, 2023 •
edited
Loading

Because of our old ISBN endpoint no longer available, we switched to a new one (based on the GVK Fetcher).
However, our existing test entries were reported back correctly with type "book". so we would need to check the code again why some ISBNs are reported back as misc.

Edit// You can always change the entry type manually: Right click on the entry - > change entry type

https://github.com/JabRef/jabref/pull/10211/files#diff-2b4f7b12839b9d7f983f456905024285786b9914417486029790d7ebd95c9edfL34-L46

Refs #10211

@Siedlerchr Siedlerchr added component: fetcher [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs labels Sep 8, 2023
Siedlerchr added a commit that referenced this issue Sep 9, 2023
@Siedlerchr
Fix isbn fetcher returning misc
fba684b 
Fixes #10348

use arrayList instead of linkedlist
@Siedlerchr Siedlerchr mentioned this issue Sep 9, 2023
Merged
6 tasks
@Siedlerchr
Copy link
Member

A fix is in the pipeline

github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2023
@Siedlerchr
Fix isbn fetcher returning misc (#10359)
9bed170 
* Fix isbn fetcher returning misc

Fixes #10348

use arrayList instead of linkedlist

* remove else case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: fetcher [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix isbn fetcher returning misc JabRef/jabref
1 participant
@Siedlerchr