Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Merge entry with DOI information" does not apply changes to entry type #1062

Closed
darkdragon-001 opened this issue Mar 30, 2016 · 4 comments
Closed

"Merge entry with DOI information" does not apply changes to entry type #1062

darkdragon-001 opened this issue Mar 30, 2016 · 4 comments
Assignees
@stefan-kolb
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@darkdragon-001
Copy link

JabRef version 3.2

Steps to reproduce:

  1. Right click on entry > Get BibTeX data from DOI
  2. Select information
  3. Replace original entry
  4. Changes are not applied!

Maybe this has to do with the fact that the previous entry had an invalid entry type (Other).
@stefan-kolb stefan-kolb added the bug Confirmed bugs or reports that are very likely to be bugs label Mar 30, 2016
@stefan-kolb
Copy link
Member

In fact it has to with the invalid entry type. Other than that it works for me. I'll investigate further.

@stefan-kolb stefan-kolb self-assigned this Mar 30, 2016
@stefan-kolb
Copy link
Member

The problem is that the GUI suggest that you can change the type of the entry but the actual logic does only compare the fields of both entries.

@oscargus You worked a little bit on the merge dialog?! Did you change anything or didn't we have this functionality at all?

@oscargus
Copy link
Contributor

oscargus commented Mar 30, 2016 via email

@stefan-kolb stefan-kolb changed the title "Merge entry with DOI information" does not apply changes "Merge entry with DOI information" does not apply changes to entry type Mar 30, 2016
@stefan-kolb
Copy link
Member

I just fixed it 😄

@koppor koppor closed this as completed in af38aa5 Mar 30, 2016
koppor added a commit that referenced this issue Mar 30, 2016
@koppor
Merge pull request #1064 from JabRef/merge-entry-type-change
9be400a 
Fix #1062 Merge entry with DOI information now also applies changes to entry type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefan-kolb stefan-kolb

Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darkdragon-001 @stefan-kolb @oscargus