Add a method to create a new link manually #11017
Comments
Siedlerchr
added
[outdated] type: enhancement
component: ui
component: entry-editor
good first issue
github-project-automation
bot
moved this to Free to take
in Candidates for University Projects
|
Hi, I'm interested in contributing to this issue, I'd appreciate if you could provide me with the assignee role. |
ThiloteE
moved this from Free to take
to Reserved
in Candidates for University Projects
|
@rahulsree May I ask for progress? |
ThiloteE
moved this from Reserved
to Free to take
in Candidates for University Projects
|
Hi, I'd like to work on this issue, Could you please assign it to me? |
ThiloteE
moved this from Free to take
to Reserved
in Candidates for University Projects
|
Welcome to the vibrant world of open-source development with JabRef! Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly. Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback. Happy coding! 🚀 |
Manual File Entry Creation: Added a new button to the LinkedFilesEditor.fxml. Clicking this button displays a textbox where users can manually enter text/URLs. [JabRef#11017]
|
As screenshot: 
We accept that for attaching files, now three clicks are necessary. We gain the benefit that the user can directly add a description. |
|
@koppor What file types can we expect to be available in the combo box? |
The whole dialogue including the combobox is already available. One "just" needs to adapt it to cover two cases: add (new), edit (existing) |
|
@Kunal77689 please open jabref, create a new library, drag and drop a PDF into it. Hold the ctrl key, otherwise it will be moved. Then go to "General" tab, Files. There you will see the pdf. Then click the edit button on the right. You will see the dialog. |
Manual File Entry Creation: Modified add button functionality so that rather than opening the file explorer, it opens a dialog box for manual file creation. [JabRef#11017]
- Deleted fxml and java files which were handling edit and add action separately and added a unified way which handles edit and add action dynamically
- Overloaded the constructor so that one will take a LinkedFile for editing, another will not take any argument.
- Removed extra blank line in LinkedFilesEditorViewModel -Added link to the pr in the CHANGELOG.md
- Fixed checkstyle erorrs
- Fixed checkstyle erorrs
- Fixed findObsoleteLocalizationKeys() error by removing unwanted keys. - Fixed findMissingLocalizationKeys() by adding "Add file link" as a key
- Renamed files from controller->view - Made sure both edit and add dialog boxes follow same layout - The add dialog box will have pdf as the default option - fixed minor bugs in some places where some "%" were removed in some of the previous commits, restored those symbols - on hover, rather than showing open, it will show add
* Add a method to create a new link manually #11017 Manual File Entry Creation: Modified add button functionality so that rather than opening the file explorer, it opens a dialog box for manual file creation. [#11017] * Updated CHANGELOG.md * Added a method to create a new link manually #11017 - Deleted fxml and java files which were handling edit and add action separately and added a unified way which handles edit and add action dynamically * Added a method to create a new link manually #11017 - Overloaded the constructor so that one will take a LinkedFile for editing, another will not take any argument. * Added a method to create a new link manually #11017 - Removed extra blank line in LinkedFilesEditorViewModel -Added link to the pr in the CHANGELOG.md * Added a method to create a new link manually #11017 - Fixed checkstyle erorrs * Added a method to create a new link manually #11017 - Fixed checkstyle erorrs * Added a method to create a new link manually #11017 - Fixed findObsoleteLocalizationKeys() error by removing unwanted keys. - Fixed findMissingLocalizationKeys() by adding "Add file link" as a key * Added a method to create a new link manually #11017 - Renamed files from controller->view - Made sure both edit and add dialog boxes follow same layout - The add dialog box will have pdf as the default option - fixed minor bugs in some places where some "%" were removed in some of the previous commits, restored those symbols - on hover, rather than showing open, it will show add * Use Java 8 Optional * Fix class names * Fix name (again) * Fix method name and reuse code * Fix double dialog initialization * Fix PDF type * Remove generated JavaDoc * Remove dead code * Re-add missing localizations --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
github-project-automation
bot
moved this from Reserved
to Done
in Candidates for University Projects
Is your suggestion for improvement related to a problem? Please describe.
Currenty, the General tab > File entries can hold either paths to local files, or links to online URLs, but when creating them manually, only local files can be added there (either by selecting a local file with the file chooser, or by downloading a URL).
This makes it difficult to use that field for other information such as e.g. links to github repositories for code related to the article.
Describe the solution you'd like
It would be good if a method to create a new file entry manually was available -- open the file entry editor with blank entries, allow filling them up manually, and create the entry with the result of that operation.
The text was updated successfully, but these errors were encountered: