Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu in entry editor displayed on primary screen (jfx 23) #11323

Closed
2 tasks done
ytzemih opened this issue May 22, 2024 · 3 comments · Fixed by #11324
Closed
2 tasks done

Context menu in entry editor displayed on primary screen (jfx 23) #11323

ytzemih opened this issue May 22, 2024 · 3 comments · Fixed by #11324

Comments

@ytzemih
Copy link

ytzemih commented May 22, 2024

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.14--2024-05-20--7dce65a Linux 6.1.0-21-amd64 amd64 Java 22.0.1 JavaFX 23-ea+18

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

I'm using i3 and saw that the context menu in the entry list is shown on the same screen as JR. But, interestingly, the context menu for a field in the entry editor is shown on the primary screen, not on the one where JR resides, see the attached screenshot.
jr-fx23-screen-menu

  1. Open JR, move it to an external screen.
  2. Create an entry and open the context menu of the entry in the list: should be shown next to the mouse pointer.
  3. Click into, e.g., the title field and open the context menu: it is shown in a bottom corner of the primary screen, but not next to the mouse pointer.
  4. Click into the search field at the top and open a context menu: should again be shown next to the mouse pointer.

I wonder whether this is a JavaFX GUI framework issue, or whether the rendering of context menus can be individually controlled by the programmer. In the latter case, there could perhaps be an easy fix.

Appendix

No response

@Siedlerchr Siedlerchr changed the title Context menu in entry editor displayed on primary screen Context menu in entry editor displayed on primary screen (jfx 23) May 22, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in JabRef UI Improvements May 22, 2024
@Siedlerchr
Copy link
Member

Okay, I think I found the issue, at least under mac it's working now....

Back in the early days we introduced this in #5352

Siedlerchr added a commit that referenced this issue May 22, 2024
Remove hack code

Fixes #11323
@Siedlerchr
Copy link
Member

Can you test this version? https://builds.jabref.org/pull/11324/merge
Note that this only fixes the context menus for the entry editor and still uses the older javafx

@ytzemih
Copy link
Author

ytzemih commented May 23, 2024

Moin @Siedlerchr, great, that one works: Context menus are at the right place. Sometimes, evil workarounds have their rationale ;) Thanks!

@github-project-automation github-project-automation bot moved this from Normal priority to Closed in JabRef UI Improvements May 23, 2024
@Siedlerchr Siedlerchr moved this to Done in Prioritization May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants