-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor user-selected keyword delimiter in MedlinePlainImporter.java #11413
Labels
[outdated] type: bug
Confirmed bugs or reports that are very likely to be bugs
Comments
Siedlerchr
added a commit
that referenced
this issue
Jun 22, 2024
adjust code with intellij suggestions Fixes #11413
Thanks for creating that issue, I was about to create one based on your reporting as well :) |
Ah, but what an improvement! Thanks. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 24, 2024
* Fix dependendency issues with commons logging update gemfx update unirest to 4.x * try again with logging module stuff * remove commons logging from merged module agian * fix transitive circular dep stuff * cleanup , fix urls * remove imports * reset config * fix keyword separator not respected in Medline importer adjust code with intellij suggestions Fixes #11413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your suggestion for improvement related to a problem? Please describe.
Jabref inserts commas between keywords imported from PubMed files, even if the user has specified another delimiter in
File > Preferences > Entries
. This is a problem with PubMed files, because Medline's subject headings (MeSH terms) include commas that should not be interpreted as delimiters.Describe the solution you'd like
If the user has specified a non-default delimiter in settings and has designated the keywords field as one of the affected fields, then the importer should apply the specified delimiter instead of always using commas as the delimiter.
Additional context
See examples and additional description here: https://discourse.jabref.org/t/preserve-pubmed-subject-headings-on-import/4362/2. That discussion is about improving the usability of imported keywords. This GitHub issue only concerns the incorrect parsing of keywords due to the presence of commas in the source data.
This problem does not apply to PubMed records retrieved through JabRef's Web Search functionality. In this case, Jabref applies the user-specified delimiter, allowing correct parsing of the imported keywords.
https://github.com/JabRef/jabref/blob/af73e4e78985eefa7d0fb94c472a99a00c323d8d/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java#L185C5-L192C1
The text was updated successfully, but these errors were encountered: