Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portuguese: UI remains in English #1182

Closed
mlep opened this issue Apr 12, 2016 · 12 comments
Closed

Brazilian Portuguese: UI remains in English #1182

mlep opened this issue Apr 12, 2016 · 12 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs internationalization i18n status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Milestone

Comments

@mlep
Copy link
Contributor

mlep commented Apr 12, 2016

JabRef version JabRef-3.3dev--snapshot--2016-04-12--master--f8bce59.jar on Linux Mint LMDE

Steps to reproduce:

  1. Options -> Preferences
  2. Select "Brazilian Portuguese"
  3. Restart JabRef
    ==> English interface...
    (all other languages work as expected)

Log:

22:03:37.907 [AWT-EventQueue-0] WARN net.sf.jabref.logic.l10n.Localization - Could not find bundles for language pt_br, switching to full english language
java.util.MissingResourceException: Can't find bundle for base name l10n/JabRef, locale pt_br
at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564) ~[?:1.8.0_66]
at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387) ~[?:1.8.0_66]
at java.util.ResourceBundle.getBundle(ResourceBundle.java:890) ~[?:1.8.0_66]
at net.sf.jabref.logic.l10n.Localization.createResourceBundles(Localization.java:41) ~[JabRef-3.3dev--snapshot--2016-04-12--master--f8bce59.jar:?]
at net.sf.jabref.logic.l10n.Localization.setLanguage(Localization.java:32) ~[JabRef-3.3dev--snapshot--2016-04-12--master--f8bce59.jar:?]
at net.sf.jabref.JabRef.start(JabRef.java:84) ~[JabRef-3.3dev--snapshot--2016-04-12--master--f8bce59.jar:?]
at net.sf.jabref.JabRefMain.lambda$main$0(JabRefMain.java:10) ~[JabRef-3.3dev--snapshot--2016-04-12--master--f8bce59.jar:?]
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) [?:1.8.0_66]
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756) [?:1.8.0_66]
at java.awt.EventQueue.access$500(EventQueue.java:97) [?:1.8.0_66]
at java.awt.EventQueue$3.run(EventQueue.java:709) [?:1.8.0_66]
at java.awt.EventQueue$3.run(EventQueue.java:703) [?:1.8.0_66]
at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_66]
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76) [?:1.8.0_66]
at java.awt.EventQueue.dispatchEvent(EventQueue.java:726) [?:1.8.0_66]
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201) [?:1.8.0_66]
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) [?:1.8.0_66]
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) [?:1.8.0_66]
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) [?:1.8.0_66]
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) [?:1.8.0_66]
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) [?:1.8.0_66]
Caused by: java.lang.NullPointerException
at java.io.Reader.(Reader.java:78) ~[?:1.8.0_66]
at java.io.InputStreamReader.(InputStreamReader.java:113) ~[?:1.8.0_66]
at net.sf.jabref.logic.l10n.EncodingControl.newBundle(EncodingControl.java:51) ~[JabRef-3.3dev--snapshot--2016-04-12--master--f8bce59.jar:?]
at java.util.ResourceBundle.loadBundle(ResourceBundle.java:1501) ~[?:1.8.0_66]
at java.util.ResourceBundle.findBundle(ResourceBundle.java:1465) ~[?:1.8.0_66]
at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1361) ~[?:1.8.0_66]
... 19 more

@Siedlerchr
Copy link
Member

I think it is just a Case-Sensitive filename problem. I will look at that

@matthiasgeiger matthiasgeiger added bug Confirmed bugs or reports that are very likely to be bugs internationalization i18n labels Apr 13, 2016
@matthiasgeiger matthiasgeiger added this to the v3.3 milestone Apr 13, 2016
@gutierrezps
Copy link

gutierrezps commented Jun 27, 2017

I'm using 3.8.2, and I'm facing the same problem. I think it's the same case issue.

@simonharrer @Siedlerchr @matthiasgeiger

Log:

12:45:11.153 [AWT-EventQueue-0] WARN  net.sf.jabref.logic.l10n.Localization - Could not find bundles for language pt_br, switching to full english language
java.util.MissingResourceException: Can't find bundle for base name l10n/JabRef, locale pt_br
	at java.util.ResourceBundle.throwMissingResourceException(Unknown Source) ~[?:1.8.0_131]
	at java.util.ResourceBundle.getBundleImpl(Unknown Source) ~[?:1.8.0_131]
	at java.util.ResourceBundle.getBundle(Unknown Source) ~[?:1.8.0_131]
	at net.sf.jabref.logic.l10n.Localization.createResourceBundles(Localization.java:44) ~[JabRef-3.8.2.jar:?]
	at net.sf.jabref.logic.l10n.Localization.setLanguage(Localization.java:35) ~[JabRef-3.8.2.jar:?]
	at net.sf.jabref.JabRefMain.start(JabRefMain.java:56) ~[JabRef-3.8.2.jar:?]
	at net.sf.jabref.JabRefMain.lambda$main$0(JabRefMain.java:40) ~[JabRef-3.8.2.jar:?]
	at java.awt.event.InvocationEvent.dispatch(Unknown Source) [?:1.8.0_131]
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source) [?:1.8.0_131]
	at java.awt.EventQueue.access$500(Unknown Source) [?:1.8.0_131]
	at java.awt.EventQueue$3.run(Unknown Source) [?:1.8.0_131]
	at java.awt.EventQueue$3.run(Unknown Source) [?:1.8.0_131]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_131]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) [?:1.8.0_131]
	at java.awt.EventQueue.dispatchEvent(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.run(Unknown Source) [?:1.8.0_131]
Caused by: java.lang.NullPointerException
	at java.io.Reader.<init>(Unknown Source) ~[?:1.8.0_131]
	at java.io.InputStreamReader.<init>(Unknown Source) ~[?:1.8.0_131]
	at net.sf.jabref.logic.l10n.EncodingControl.newBundle(EncodingControl.java:51) ~[JabRef-3.8.2.jar:?]
	at java.util.ResourceBundle.loadBundle(Unknown Source) ~[?:1.8.0_131]
	at java.util.ResourceBundle.findBundle(Unknown Source) ~[?:1.8.0_131]
	... 20 more

@koppor koppor reopened this Jun 27, 2017
@koppor
Copy link
Member

koppor commented Jun 27, 2017

Operating system? How do you start JabRef?

@gutierrezps
Copy link

I'm running the standalone jar by double clicking on it. Windows 10 x64, Java 8 update 131.

@rscaputo
Copy link

rscaputo commented Jul 7, 2017

Same problem here with Jabref 3.8.2 Win10x64, Languge UI doesn't change after language is setup to Brazilian Portuguese in preferences.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 7, 2017

In the lastest snapshot of JabRef 4.x I can't reproduce this. Due to some missing translations, there are still menu items in English, but the rest looks translated to me:
grafik

Btw, you are very welcome to improve the translations, by adding translations for missing strings.
All information about translations can be found here: https://help.jabref.org/en/TranslatingGUI

@Siedlerchr Siedlerchr added status: waiting-for-feedback The submitter or other users need to provide more information about the issue and removed bug Confirmed bugs or reports that are very likely to be bugs labels Jul 7, 2017
@rscaputo
Copy link

rscaputo commented Jul 7, 2017

@Siedlerchr updated to jabref 4 beta and the problem persisted.

JabRef 4.0.0-beta
Windows 10 10.0 amd64
Java 1.8.0_131

Steps to reproduce:

  1. Installed JabRef 4.0.0-beta
  2. Changed Language to Brazilian Portuguese in Preferences
  3. Restarted Jabref
  4. Language Didn't change
  5. Other languages worked fine.
Detail information:
Could not find bundles for language pt_br, switching to full english language
java.util.MissingResourceException: Can't find bundle for base name l10n/JabRef, locale pt_br
	at java.util.ResourceBundle.throwMissingResourceException(Unknown Source)
	at java.util.ResourceBundle.getBundleImpl(Unknown Source)
	at java.util.ResourceBundle.getBundle(Unknown Source)
	at org.jabref.logic.l10n.Localization.createResourceBundles(Localization.java:52)
	at org.jabref.logic.l10n.Localization.setLanguage(Localization.java:43)
	at org.jabref.JabRefMain.start(JabRefMain.java:69)
	at org.jabref.JabRefMain.lambda$start$0(JabRefMain.java:53)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.NullPointerException
	at java.io.Reader.<init>(Unknown Source)
	at java.io.InputStreamReader.<init>(Unknown Source)
	at org.jabref.logic.l10n.EncodingControl.newBundle(EncodingControl.java:51)
	at java.util.ResourceBundle.loadBundle(Unknown Source)
	at java.util.ResourceBundle.findBundle(Unknown Source)
	... 20 more

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Jul 7, 2017
@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 7, 2017

Okay, thanks for your test. I could reproduce this now when starting the jar directly or by using java -jar JabRef...jar
Because running from gradle/Eclipse was okay:
Theoretically this should have been fixed in
85e71ea

Ah I just see it's a regression bug. The code has changed.

Siedlerchr added a commit that referenced this issue Jul 7, 2017
Fix regression bug #1182
Pass language and country as separate args for Locale constructor
koppor pushed a commit that referenced this issue Jul 9, 2017
- Fix regression bug #1182
- Pass language and country as separate args for Locale constructor
@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 9, 2017

The bug should be fixed now.
Could you please try the latest snapshot?
http://builds.jabref.org/master/

@rscaputo
Copy link

rscaputo commented Jul 9, 2017

@Siedlerchr, unlike the other versions I installed before, this snapshot is not being allowed to install by my antivirus...

Antivirus: Panda Protection V. 18.01.00
Detected virus W32/Exploit.gen

@Siedlerchr
Copy link
Member

Thanks for your feedback. That's a false positive, I did a scan with Virustotal both 64 bit and 432bit.
https://www.virustotal.com/de/file/98151afd7b241e7594ada8bb467ac4d388a1a101ca33651dcd315be175cae8af/analysis/1499623453/

https://www.virustotal.com/de/file/408f089a02058ea8f8b279186e4f5a93d34e9440320af515ced90ea1000e2322/analysis/1499623163/

I don't know if you have an option to white list the application.
@koppor Maybe we need to concact the people at Panda to whitellist JabRef?

Anyway I close this bug as I tested it with the current snapshot and it worked fine.

As wirtten earlier, we would be happy if you (or someone else from the Brazilian Portugese speaking users) could contribute to the translation of the user Interface.

@rscaputo
Copy link

rscaputo commented Jul 9, 2017

Thanks @Siedlerchr, tested here and is translating now! Thanks for the quick answer too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs internationalization i18n status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

6 participants